Fix rosa asset naming for v1.2.65

[alexellis]

rosa v1.2.65 changed asset naming: rosa_Linux_x86_64.tar.gz → rosa_linux_amd64.zip (lowercase OS, amd64 instead of x86_64, zip instead of tar.gz). Updates the template and tests to the new naming.

Naming change queried upstream in openshift/rosa#3499 - pending their answer on whether it's intentional, this fixes our URLs against the current assets.

Verified: go run . get rosa --os linux --arch x86_64 --version v1.2.65 downloads a valid ELF binary; unit test updated to v1.2.65 asset names.

Linked issue filed upstream: openshift/rosa#3499

[reviewfn]

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

• Updates the ROSA download asset template to lowercase OS names, amd64, and .zip archives.
• Updates the ROSA URL test fixture from v1.2.46 to v1.2.65.
• The new template fixes the current v1.2.65 asset naming described in the PR.
• The template is not version-aware, so older explicitly requested ROSA versions now resolve to asset names that did not exist under the prior tested scheme.

Approval rating (1-10)

6/10. The current release path is addressed, but the change regresses explicit downloads of older ROSA versions.

Summary per file

Summary per file

File path	Summary
pkg/get/tools.go	Changes ROSA asset naming template to v1.2.65 zip naming.
pkg/get/get_test.go	Updates ROSA URL expectations to v1.2.65 asset names.

Overall Assessment

The PR appears to fix ROSA URL generation for v1.2.65, but it does so by replacing the template globally. Since arkade get accepts an explicit --version, users asking for older ROSA releases will now get URLs using the new naming even though the previously covered v1.2.46 assets used the old Darwin/Linux/Windows, x86_64, and .tar.gz pattern. That is a behavior regression in a supported code path and should be handled before merging.

Detailed Review

Detailed Review

Findings

Medium: Older explicit ROSA versions now resolve to the wrong asset names

pkg/get/tools.go:5046

The updated BinaryTemplate applies the v1.2.65 naming convention to every requested ROSA version. That fixes v1.2.65, but it breaks versions that still use the old asset scheme. The test previously covered v1.2.46 URLs such as rosa_Linux_x86_64.tar.gz; after this change, arkade get rosa --version v1.2.46 --os linux --arch x86_64 would resolve to rosa_linux_amd64.zip, which is inconsistent with the old naming shown in the removed test expectations.

This matters because GetURL uses the supplied version directly when users pass --version, so the latest-release fix also changes historical version resolution. Make the template version-aware for the naming transition, or otherwise preserve the old naming path for known pre-v1.2.65 versions while using the new path for the current release naming.

AI agent details.

Agent processing time: 1m10.986s
Environment preparation time: 4.305s
Total time from webhook: 1m19.717s