axis.py: Add clean() method to the AxiStreamSink#101
Open
BZab wants to merge 1 commit intoalexforencich:masterfrom
Open
axis.py: Add clean() method to the AxiStreamSink#101BZab wants to merge 1 commit intoalexforencich:masterfrom
BZab wants to merge 1 commit intoalexforencich:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During more complex testing scenario where I have multiple test factories, I came across a bug.
If the tests from the first factory have ended with some frames not received by the TB (because eg. that interface was ignored in prior tests), in the first few tests from the next factory the Sink was receiving ghost frames from the prior tests even if there was no valid data on the bus.
The simplest workaround for this is to clear all Sinks at the end of each test.