Skip to content

Fix ffmpeg dependency and don't import project in setup.py #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashtuchkin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ffmpeg dependency and don't import project in setup.py #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ More information on the format is available on the
The primay aim of this project was to be able to extract GPS tracks
from GoPro video files, so the GPS part is more tested.

We use `python-ffmpeg` to extract the GPMF stream from video files.
We use `ffmpeg-python` to extract the GPMF stream from video files.

```python
import gpmf
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
numpy
matplotlib
gpxpy
python-ffmpeg
ffmpeg-python
geopandas
descartes
contextily
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from setuptools import setup, find_packages
import pathlib
from gpmf import __version__
__version__ = "0.1"
Copy link
Copy Markdown

@kalvdans kalvdans Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Remove the __version__ definition in gpmf/__init__.py too so we don't have duplicate definitions that risk being out of sync.


HERE = pathlib.Path(__file__).parent
README = (HERE / "README.md").read_text()
Expand All @@ -17,7 +17,7 @@
packages=find_packages(),
install_requires=[
"numpy", "pandas", "gpxpy",
"python-ffmpeg", "geopandas",
"ffmpeg-python", "geopandas",
"contextily", "descartes"
],
url="https://github.com/alexis-mignon/pygpmf"
Expand Down