Add configuration option for 2 digit hours#287
Open
oyvindwe wants to merge 1 commit intoalexpfau:mainfrom
Open
Add configuration option for 2 digit hours#287oyvindwe wants to merge 1 commit intoalexpfau:mainfrom
oyvindwe wants to merge 1 commit intoalexpfau:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add configuration option for 2 digit hours.
Also corrected doc strings in nearby code. Let me know if you prefer this to be refactored to a separate PR.
Related Issue
Based on feedback in PR #240
Motivation and Context
2 digit hours is a common when using 24 hours time format. See e.g. ISO 8601 or Google Calendar UI.
For flexibility (and avoding complex logic in configuration), this is also offered for 12 hours time format.
How Has This Been Tested
Tested by tweaking the time format configuration in the UI. Both variants work for system, 12h, and 24h time formats.
Types of changes
Checklist
npm run lintandnpm run format)