Conversation
There was a problem hiding this comment.
Pull request overview
This PR resolves race conditions in the AbStochKin simulation when running in parallel mode by refactoring how transition probabilities are handled in regulated processes.
Key Changes:
- Refactored regulated process methods to calculate transition probabilities in local variables instead of modifying the shared
self.trans_pdictionary - Added optional
transition_pparameter to_order_0,_order_1, and_order_2methods to accept pre-calculated transition probabilities - Added Mermaid diagram documenting the simulation architecture
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/simulation_architecture.mmd | New Mermaid flowchart documenting the simulation architecture and component relationships |
| abstochkin/agentstatedata.py | Reformatted np.concatenate call in __post_init__ for improved readability (no functional changes) |
| abstochkin/_simulation_methods.py | Resolved race condition by passing transition probabilities as parameters instead of modifying shared dictionary; updated 12 process-handling methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lve-race-conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the simulation parameters was not thread safe. This PR fixes this issue.
Key Changes:
self.trans_pdictionary