Update domain for ban_data_gouv_fr adapter

[Intrepidd]

The official domain has changed a while ago, the old one was still working but yesterday there was an incident affecting only the old domain. It's back up again but it is probably best to use the official domain.

Reference: https://geoservices.ign.fr/documentation/services/services-geoplateforme/geocodage

[alexreisner]

Excellent, thanks!

[sallesma]

@Intrepidd I started to have a lot errors after upgrading the geocoder gem.
My calls to the BAN triggered this error:

> Geocoder.search("_valid address_", lookup: :ban_data_gouv_fr)
(cyke):1:in '<main>': Geocoder::LookupTimeout (Geocoder::LookupTimeout)
.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/net-http-0.6.0/lib/net/http.rb:1665:in 'TCPSocket#initialize': Failed to open TCP connection to data.geopf.fr:80 (execution expired) (Net::OpenTimeout)

I tried again with use_https: true in my config and it works well.
Maybe we should force https when using the BAN ?

[Intrepidd]

@sallesma sorry to hear that, my config is already use_https so I didn't test on regular HTTP.

Does it fail 100% of the time on regular HTTP ? or is is transient ?

[sallesma]

I would think so, I started seeing errors when we upgraded geocoder.

• We have a fallback to mapbox on production
• Our timeout is set at 20 seconds in the configuration
• We geocode twice on this endpoint and it always take 40s

So I think we always hit the issue.

Also, the documentation here only displays https examples

[sallesma]

I've released a new version with use_https: true a few minutes ago and I'm monitoring if this was the real cause of the issue. If it is, I'll open a PR to force https when using the BAN

Edit: It is the case, my endpoint now responds within 0.3s, just after using https