[pull] main from permitio:main#3
Merged
pull[bot] merged 1 commit intoalexstojda:mainfrom Jun 23, 2025
Merged
Conversation
* Enhance Consistent Updates feature with new role unassignment endpoints - Updated `FactsClient` to support optional query parameters in `build_forward_request` and `send_forward_request` methods, improving flexibility in request handling. - Added new DELETE endpoints for unassigning user roles and deleting role assignments in the `facts_router`, allowing for better management of user roles with a `return_deleted` query parameter. - Refactored `forward_request_then_wait_for_update` to accommodate the new query parameters, ensuring consistent behavior across requests. * Refactor FactsClient methods to remove optional query parameters - Updated `build_forward_request` and `send_forward_request` methods in `FactsClient` to eliminate the optional `query_params` argument, simplifying the request handling process. - Adjusted related calls in `facts_router` to align with the new method signatures, ensuring consistent behavior across the application. * fix pre-commit * Enhance FactsClient and router with query parameter support - Updated `FactsClient` methods to accept optional `query_params`, improving flexibility in request handling. - Introduced a `pre_return_callback` parameter to `convert_response` for custom response processing. - Modified `facts_router` endpoints to utilize the new query parameter functionality, specifically for handling `return_deleted` logic in user role management. - Added a utility function to convert 200 responses to 204, enhancing response consistency. * Refactor FactsClient and router to remove pre_return_callback parameter - Eliminated the `pre_return_callback` parameter from `convert_response` in `FactsClient`, simplifying response handling. - Updated `unassign_user_role` and `delete_role_assignment` functions in `facts_router` to remove references to `pre_return_callback`, ensuring consistent response processing. - Adjusted `forward_request_then_wait_for_update` to align with the new method signature, enhancing clarity and maintainability. * Refactor query parameter handling in FactsClient - Updated the `FactsClient` to use a separate variable for merging query parameters, improving code clarity. - Simplified the request parameter construction by directly using the new variable, enhancing maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )