Skip to content

Conversation

@rimas-kudelis
Copy link
Contributor

@rimas-kudelis rimas-kudelis commented Feb 21, 2025

Fixes #1684

@rimas-kudelis rimas-kudelis force-pushed the feat/public-dir branch 2 times, most recently from 1fc0209 to ee93262 Compare February 21, 2025 16:06
@rimas-kudelis
Copy link
Contributor Author

rimas-kudelis commented Feb 21, 2025

@alextselegidis, this is version 1 of the PR. Please let me know if you want any changes to it.

The result looks even better when CodeIgniter is under vendor (I implore you to at least have a look at #1680!): in combination with that change, the app is cleanly split into three very distinct directories: public/ holds the index script and public files, application holds private PHP files which belong to this app, and vendor/ contains third-party code.

In another CI3 project, I additionally renamed application to app, as is done in CI4, but that's not necessary.

@rimas-kudelis
Copy link
Contributor Author

rimas-kudelis commented Feb 27, 2025

Version 2 is very much simplified, but also improved. I moved git-tracked assets back to their original place, but modified the gulpfile to generate their production versions (and copy images) to public/assets. This way, the diff is much smaller, and there's much clearer separation between source and production assets. I also undid irrelevant docker-compose.yml changes. The diff now only affects four files and npx gulp build generates a zip which seems what I would expect.

@alextselegidis
Copy link
Owner

Hello!

Thanks for this PR.

The application restructuring is done step by step with each major release, so it can be that this change is delayed until merged.

I will leave this PR open for now until the time for the assets move comes.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants