Add Storybook #2300
Open
Add Storybook #2300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwilson
force-pushed
the
add-storybook
branch
2 times, most recently
from
5c96b9a to
560879e
Compare
alexwilson
force-pushed
the
add-storybook
branch
2 times, most recently
from
5c4ff5e to
eb6a588
Compare
alexwilson
force-pushed
the
add-storybook
branch
7 times, most recently
from
0c2ba9b to
962f413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Something I've wanted for ages is a formal way of developing components independently from any consuming websites.
What?
@alexwilson/legacy-componentsto be agnostic of theirLinkimplementation. This is a hack, and I'd like to revisit in the future because ... ew.@alexwilson/legacy-components.Anything else?
Storybook will build when it doesn't have global scope, but won't include any components. I need some way of ensuring that the build process aware of this.