added class and if check for unchanged stocks #7
Open
ColinRhys wants to merge 1 commit intoalexyak:masterfrom
Open
added class and if check for unchanged stocks #7ColinRhys wants to merge 1 commit intoalexyak:masterfrom
ColinRhys wants to merge 1 commit intoalexyak:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new class for stocks that are unchanged. This class makes the 0 grey instead of red. Seeing a stock ribbon with a bunch of red zeros can be scary. I have included an image from thinkorswim’s iPhone app showing /ZT[M8] the 2-year treasury bond futures unchanged and the 0’s are white. Since the ticker symbols are already white I thought grey would be a good choice.
Any stock could be unchanged randomly throughout the day even though it is unlikely. In the morning before the market opens the API is showing a number of the stocks at 0. This is when I first saw all of the red zeros and then looked at the code.
The first photo is the example photo from thinkorswim’s iPhone app the second is the version of stock ribbon with grey zero on TBT.
https://imgur.com/a/Ecosh