Fix crash when first message exceeds max token length.#18
Open
tylerstillwater wants to merge 3 commits intoalfianlosari:mainfrom
Open
Fix crash when first message exceeds max token length.#18tylerstillwater wants to merge 3 commits intoalfianlosari:mainfrom
tylerstillwater wants to merge 3 commits intoalfianlosari:mainfrom
Conversation
| private func generateMessages(from text: String, systemText: String) -> [Message] { | ||
| var messages = [systemMessage(content: systemText)] + historyList + [Message(role: "user", content: text)] | ||
| if gptEncoder.encode(text: messages.content).count > 4096 { | ||
| if !historyList.isEmpty() { |
Author
There was a problem hiding this comment.
Thanks! Working on this now. I'm very new to Swift and made this edit in a github codespace. This solution doesn't work anyway. Something more complex is required.
Merge recent changes on main repository
Author
|
I've pushed a commit that correctly fixes this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During encoding, we check to see if the latest
textto be encoded and sent to ChatGPT exceeds our maximum token length of 4096. If it does, we throw an error, as this message can never function correctly.