Skip to content

no_std + alloc crate #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

no_std + alloc crate #6

wants to merge 3 commits into from

Conversation

algesten
Copy link
Owner

No description provided.

@algesten algesten mentioned this pull request Nov 28, 2024
Open
@brandonros
Copy link

could you give https://github.com/brandonros/ureq_wasm_ui a look and help me track down where the std::io usage is coming from (it's in ureq crate but I'm not sure exactly where)? Even if we stub it out with "panic if wasm32 platform", I could help implement "fetch" from there?

@algesten
Copy link
Owner Author

I can have a look tomorrow!

This PR fixes only ureq-proto, which is underpinning ureq. So there is still work I need to do in ureq itself. Is this test checking ureq-proto or ureq?

brandonros
brandonros reviewed Dec 7, 2024
View reviewed changes
src/client/amended.rs
@@ -1,4 +1,5 @@
use std::mem;
use alloc::string::ToString;
use core::mem;

use http::{HeaderMap, HeaderName, HeaderValue, Method, Request, Uri, Version};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this using the http crate from hyper? would you want to try from this branch? hyperium/http#732 otherwise i'm confused how no_std is pulling in a std crate?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be where it breaks down. The http crate working in webasm is central to this effort.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyperium/http#749 seems pretty good... are we able to build off of that?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! We should be able to. Let's hope they merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@brandonros brandonros brandonros left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@algesten @brandonros