Fix InvalidOperationException in HttpRequestHeadersExtensions.Fill due to unsafe enumeration #867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a concurrency issue where
HttpRequestHeadersExtensions.Fill()
enumerates a sharedIDictionary<string, string>
that may be modified by another thread, resulting in:System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
This happens during high-concurrency scenarios, like parallel calls to
SaveObjectsAsync
, when request headers are reused across threads.Fix: Convert the dictionary to a list before enumeration using
.ToList()
to ensure thread-safe iteration.This change does not alter behaviour but protects against intermittent runtime exceptions.
Related issue: [bug]: InvalidOperationException: Collection was modified; enumeration operation may not execute.