fix(indexing): replaceAllObjects blocked if called for non-existent index (#699)

Author: VladislavFitz

algolia/search/index_objects.go

@@ -344,6 +344,29 @@ func (i *Index) browserForObjects(params searchParams, opts ...interface{}) func
 // prevent issues, one may want to pass the opt.Safe(true) option. Note that
 // passing this option will make the method blocking.
 func (i *Index) ReplaceAllObjects(objects interface{}, opts ...interface{}) (g *wait.Group, err error) {
+	safe := iopt.ExtractSafe(opts...).Get()
+
+	exists, err := i.Exists()
+	if err != nil {
+		err = fmt.Errorf("cannot check if the index exists: %v", err)
+		return
+	}
+
+	if !exists {
+		resSaveObjects, e := i.SaveObjects(objects, opts...)
+		if e != nil {
+			err = fmt.Errorf("cannot save objects to the index: %v", e)
+			return
+		}
+		if safe {
+			if e := resSaveObjects.Wait(); e != nil {
+				err = fmt.Errorf("error while waiting for saving objects to the index: %v", e)
+				return
+			}
+		}
+		return
+	}
+
 	tmpIndex := i.client.InitIndex(fmt.Sprintf(
 		"%s_tmp_%d",
 		i.name,
@@ -359,7 +382,6 @@ func (i *Index) ReplaceAllObjects(objects interface{}, opts ...interface{}) (g *
 	}()
 
 	g = wait.NewGroup()
-	safe := iopt.ExtractSafe(opts...).Get()
 	optsWithScopes := opt.InsertOrReplaceOption(opts, opt.Scopes("rules", "settings", "synonyms"))
 
 	resCopyIndex, err := i.client.CopyIndex(i.name, tmpIndex.name, optsWithScopes...)

cts/index/replacing_test.go

@@ -107,3 +107,17 @@ func TestReplacing(t *testing.T) {
 		require.NoError(t, err)
 	}
 }
+
+func TestReplacingNonExistentIndex(t *testing.T) {
+	t.Parallel()
+	_, index, _ := cts.InitSearchClient1AndIndex(t)
+
+	_, err := index.ReplaceAllObjects([]map[string]string{{"objectID": "one"}, {"objectID": "two"}}, opt.Safe(true))
+	require.NoError(t, err)
+
+	err = index.GetObject("one", nil)
+	require.NoError(t, err)
+
+	err = index.GetObject("two", nil)
+	require.NoError(t, err)
+}