You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
| Q | A
| ----------------- | ----------
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Related Issue | -
| Need Doc update | no
## Describe your change
This PR split the unit tests and the integration tests in CircleCI into dedicated jobs: `unit-tests` & `integration-tests`.
## What problem is this fixing?
The `integrations-tests` require credentials, and those credentials are **NOT** forwarded to fork pull requests. It means that **ALL** pull requests made by any external contributor is failing from the CI point of view. The idea is to disable the integrations tests suite on fork pull request because anyway they won't pass (see [CircleCI documentation](https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/)).
## Next steps
We have to change the required checks from `test-1.XX` to ` unit-tests-1.XX`. The integration tests become optional but since they cannot run on every PRs anyway it makes no sense to have them required. If they are failing it's our responsibility to check the output.
0 commit comments