Fix Defaults reference in Algolia::Transport::RetryStrategy #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knapo
approved these changes
Aug 28, 2024
|
Hello, any updates on that PR ? |
Author
The issue hasn't been fixed yet by any other PR, so this is still relevant. |
Author
|
@shortcuts could you please take a look at this PR? |
Member
|
Hey there really sorry I didn't saw the notifications there, cc @millotp we should port this to https://github.com/algolia/api-clients-automation |
Contributor
|
Since this repository is generated, I moved the changes to algolia/api-clients-automation#4027, it will be available in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the Algolia::Transport::RetryStrategy still references the Defaults module, which was removed sometime between version 2 and now. This fixes the broken reference.