-
Notifications
You must be signed in to change notification settings - Fork 62
feat!: support new algoliasearch and django versions #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 31 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
099b778
chore: upgrade tooling
shortcuts 6b398ad
chore: update ci
shortcuts 2587b37
chore: update pr and issue template
shortcuts 9d9c876
chore: minor python version
shortcuts 2f9aa46
chore: use pip3
shortcuts ca426a7
chore: format and setup linter
shortcuts 5907b3e
chore: setup pyright
shortcuts 523958e
fix: use algoliasearch v4 syntax
shortcuts f6dd4e7
fix: some types
shortcuts 1e0054b
fix: remove user agent for now
shortcuts d232e1a
fix: some tests and types
shortcuts 2efcc03
chore: remove deprecation notices
shortcuts f0db28d
fix: assertions
shortcuts ace44b1
fix: django settings upgrade and some cleanup
shortcuts 466d528
fix: prepare for next python release
shortcuts bf70da4
chore: format
shortcuts 2cf07af
chore: some types improvements
shortcuts bc74b9d
fix: decorators
shortcuts 19f93b7
fix: requirements and install from source
shortcuts 3b5b25b
fix: circular import
shortcuts c85fce2
fix: pull from source until end of bfcm
shortcuts 8f1b561
fix: lint before tests
shortcuts 790dce6
chore: add timeout
shortcuts 893f3f4
fix: types and
shortcuts 999f115
fix: more tests
shortcuts f7e1282
fix: commands and index tests
shortcuts be333a1
trigger
shortcuts 651654e
fix: lint and ci
shortcuts f4f6012
trigger
shortcuts 4a5d054
chore: longer timeout?
shortcuts d4b2085
chore: ignore at the correct spot
shortcuts 2fb46ff
chore: issue template dir
shortcuts 5df5c84
chore: review
shortcuts 4a4031f
chore: pull latest
shortcuts 5a07fe6
chore: remove TODO
shortcuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,73 @@ | ||
<!-- | ||
Please use this issue tracker only for reporting bugs or feature requests. | ||
name: Bug Report | ||
description: File a bug report. | ||
title: '[bug]: ' | ||
labels: ['bug', 'triage'] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
## Please help us help you! | ||
|
||
If you need support, please use: | ||
|
||
- our community forum | ||
http://discourse.algolia.com | ||
|
||
- StackOverflow with the `algolia` tag | ||
https://stackoverflow.com/questions/tagged/algolia | ||
Before filing your issue, ask yourself: | ||
- Is there an issue already opened for this bug? | ||
- Can I reproduce it? | ||
|
||
--> | ||
If you are not sure about the origin of the issue, or if it impacts your customer experience, please contact [our support team](https://alg.li/support). | ||
- type: textarea | ||
attributes: | ||
label: Description | ||
description: A clear and concise description of what the bug is. | ||
validations: | ||
required: true | ||
- type: dropdown | ||
id: python version | ||
attributes: | ||
label: python version | ||
description: What is the Python version you've reproduced the error with | ||
options: | ||
- 3.8 | ||
- 3.9 | ||
- 3.10 | ||
- 3.11 | ||
- 3.12 | ||
- 3.13 | ||
validations: | ||
required: true | ||
- type: dropdown | ||
id: django version | ||
attributes: | ||
label: Django version | ||
description: What is the Django version you've reproduced the error with | ||
options: | ||
- 4.0 | ||
- 4.1 | ||
- 4.2 | ||
- 5.0 | ||
- 5.1 | ||
validations: | ||
required: true | ||
- type: textarea | ||
attributes: | ||
label: Steps to reproduce | ||
description: Write down the steps to reproduce the bug, please include any information that seems relevant for us to reproduce it properly | ||
placeholder: | | ||
1. Use method `...` | ||
2. With parameters `...` | ||
3. See error | ||
validations: | ||
required: true | ||
- type: textarea | ||
id: logs | ||
attributes: | ||
label: Relevant log output | ||
description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. | ||
render: shell | ||
- type: checkboxes | ||
attributes: | ||
label: Self-service | ||
description: | | ||
If you feel like you could contribute to this issue, please check the box below. This would tell us and other people looking for contributions that someone's working on it. | ||
If you do check this box, please send a pull request within 7 days so we can still delegate this to someone else. | ||
options: | ||
- label: I'd be willing to fix this bug myself. | ||
|
||
- Django version: | ||
- Algolia Django integration version: | ||
- Algolia Client Version: #.#.# | ||
- Language Version: | ||
|
||
### Description | ||
|
||
|
||
### Steps To Reproduce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,17 @@ | ||
| Q | A | ||
| ----------------- | ---------- | ||
| Bug fix? | yes/no | ||
| New feature? | yes/no <!-- please update the /CHANGELOG.md file --> | ||
| BC breaks? | no | ||
| Related Issue | Fix #... <!-- will close issue automatically, if any --> | ||
| Need Doc update | yes/no | ||
## 🧭 What and Why | ||
|
||
🎟 JIRA Ticket: | ||
|
||
## Describe your change | ||
### Changes included: | ||
|
||
<!-- | ||
Please describe your change, add as much detail as | ||
necessary to understand your code. | ||
--> | ||
|
||
## What problem is this fixing? | ||
## 🧪 Test | ||
|
||
<!-- | ||
Please include everything needed to understand the problem, | ||
its context and consequences, and, if possible, how to recreate it. | ||
Please include detail that could help the maintainers of this repository | ||
to assert the changes you've made (e.g. written tests, scenarios). | ||
--> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ | |
|
||
| Name | Email | | ||
|-----------------|---------------------| | ||
| Paul-Louis Nech | [email protected] | | ||
| Algolia | [email protected] | | ||
shortcuts marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.