Merge pull request #1369 from algolia/release/3.10.4

mohitalgolia · web-flow · commit 52ef8f560735 · 2023-06-07T11:48:32.000+05:30
Release/3.10.4
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # CHANGE LOG
 
+## 3.10.4
+
+### Bug Fixes
+- Fixed the checkout console “tagName” error due to autocomplete not defined by ensuring proper loading of the js library
+- Fixed the undefined config variable issue in recommend
+- Fixed the issue with logged in user token for click and conversion when personification is turned off.
+- Fixed the issue with Items click position for Recommend Events
+- Fixed the issue with Hyphen converted to slash in facets.
+
+
 ## 3.10.3
 
 ### UPDATES
diff --git a/Observer/Insights/CustomerLogin.php b/Observer/Insights/CustomerLogin.php
@@ -31,7 +31,7 @@ public function execute(Observer $observer)
         /** @var Customer $customer */
         $customer = $observer->getEvent()->getCustomer();
 
-        if ($this->insightsHelper->getPersonalizationHelper()->isPersoEnabled($customer->getStoreId())) {
+        if ($this->insightsHelper->getConfigHelper()->isClickConversionAnalyticsEnabled($customer->getStoreId()) || $this->insightsHelper->getPersonalizationHelper()->isPersoEnabled($customer->getStoreId())) {
             $this->insightsHelper->setUserToken($customer);
         }
     }
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 Algolia Search for Magento 2
 ============================
 
-![Latest version](https://img.shields.io/badge/latest-3.10.3-green)
+![Latest version](https://img.shields.io/badge/latest-3.10.4-green)
 ![Magento 2](https://img.shields.io/badge/Magento-2.4.x-orange)
 
 ![PHP](https://img.shields.io/badge/PHP-8.2%2C8.1%2C7.4-blue)
diff --git a/composer.json b/composer.json
@@ -3,7 +3,7 @@
   "description": "Algolia Search integration for Magento 2",
   "type": "magento2-module",
   "license": ["MIT"],
-  "version": "3.10.3",
+  "version": "3.10.4",
   "require": {
     "magento/framework": "~102.0|~103.0",
     "algolia/algoliasearch-client-php": "3.2",
diff --git a/etc/module.xml b/etc/module.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Algolia_AlgoliaSearch" setup_version="3.10.3">
+    <module name="Algolia_AlgoliaSearch" setup_version="3.10.4">
         <sequence>
             <module name="Magento_Theme"/>
             <module name="Magento_Backend"/>
diff --git a/view/frontend/requirejs-config.js b/view/frontend/requirejs-config.js
@@ -27,7 +27,6 @@ var config = {
         'rangeSlider'     : 'Algolia_AlgoliaSearch/navigation/range-slider-widget',
     },
     deps  : [
-        'algoliaAutocomplete',
         'algoliaInstantSearch',
         'algoliaInsights'
     ],
diff --git a/view/frontend/templates/autocomplete.phtml b/view/frontend/templates/autocomplete.phtml
@@ -7,5 +7,12 @@ $catalogSearchHelper = $blockInstance->getCatalogSearchHelper();
 
 // Render form with autocomplete input
 if ($config->isAutoCompleteEnabled()) : ?>
+    <script type="text/x-magento-init">
+        {
+            "*": {
+                "algoliaAutocomplete": {}
+            }
+        }
+    </script>
     <div id="algoliaAutocomplete" class="block block-search algolia-search-block algolia-search-input"></div>
 <?php endif;?>
diff --git a/view/frontend/templates/instant/facet.phtml b/view/frontend/templates/instant/facet.phtml
@@ -1,7 +1,7 @@
 <script type="text/template" id="refinements-lists-item-template">
     <label class="{{cssClasses.label}} {{#isRefined}}checked{{/isRefined}}">
         <input class="{{cssClasses.checkbox}}" {{#isRefined}}checked{{/isRefined}} type="checkbox" value="{{value}}" />
-        {{value}}
+        {{label}}
         <span class="{{cssClasses.count}}">{{count}}</span>
     </label>
-</script>
+</script>
diff --git a/view/frontend/web/insights.js b/view/frontend/web/insights.js
@@ -150,8 +150,7 @@ define(
                                 var eventData = self.buildEventData(
                                     event.eventName,
                                     $this.data('objectid'),
-                                    $this.data('indexname') ? $this.data('indexname') : self.defaultIndexName,
-                                    $this.data('position')
+                                    $this.data('indexname') ? $this.data('indexname') : self.defaultIndexName
                                 );
 
                                 self.trackClick(eventData);
diff --git a/view/frontend/web/internals/template/recommend/products.js b/view/frontend/web/internals/template/recommend/products.js
@@ -4,12 +4,11 @@ define([], function () {
             let correctFKey = getCookie('form_key');
             let action = algoliaConfig.recommend.addToCartParams.action + 'product/' + item.objectID + '/';
             if(correctFKey != "" && algoliaConfig.recommend.addToCartParams.formKey != correctFKey) {
-                config.recommend.addToCartParams.formKey = correctFKey;
+                algoliaConfig.recommend.addToCartParams.formKey = correctFKey;
             }
-            this.config = algoliaConfig;
             this.defaultIndexName = algoliaConfig.indexName + '_products';
             return  html`<div class="product-details">
-                <a class="recommend-item product-url" href="${item.url}" data-objectid=${item.objectID}  data-index=${this.defaultIndexName}>
+                <a class="recommend-item product-url" href="${item.url}" data-objectid=${item.objectID} data-position=${item.position}  data-index=${this.defaultIndexName}>
                     <img class="product-img" src="${item.image_url}" alt="${item.name}"/>
                     <p class="product-name">${item.name}</p>
                     ${addTocart && html`
diff --git a/view/frontend/web/recommend.js b/view/frontend/web/recommend.js
@@ -10,7 +10,7 @@ define([
     if (typeof algoliaConfig === 'undefined') {
         return;
     }
-    
+
     return function (config, element) {
         algoliaBundle.$(function ($) {
             this.defaultIndexName = algoliaConfig.indexName + '_products';
@@ -27,6 +27,12 @@ define([
                         indexName,
                         objectIDs: config.algoliObjectId,
                         maxRecommendations: algoliaConfig.recommend.limitFBTProducts,
+                        transformItems:function (items) {
+                            return items.map((item, index) => ({
+                                ...item,
+                                position: index + 1,
+                            }));
+                        },
                         headerComponent({html}) {
                             return recommendProductsHtml.getHeaderHtml(html,algoliaConfig.recommend.FBTTitle);
                         },
@@ -42,6 +48,12 @@ define([
                         indexName,
                         objectIDs: config.algoliObjectId,
                         maxRecommendations: algoliaConfig.recommend.limitRelatedProducts,
+                        transformItems:function (items) {
+                            return items.map((item, index) => ({
+                                ...item,
+                                position: index + 1,
+                            }));
+                        },
                         headerComponent({html}) {
                             return recommendProductsHtml.getHeaderHtml(html,algoliaConfig.recommend.relatedProductsTitle);
                         },
@@ -60,6 +72,12 @@ define([
                     recommendClient,
                     indexName,
                     maxRecommendations: algoliaConfig.recommend.limitTrendingItems,
+                    transformItems:function (items) {
+                        return items.map((item, index) => ({
+                            ...item,
+                            position: index + 1,
+                        }));
+                    },
                     headerComponent({html}) {
                         return recommendProductsHtml.getHeaderHtml(html,algoliaConfig.recommend.trendingItemsTitle);
                     },
@@ -76,6 +94,12 @@ define([
                     recommendClient,
                     indexName,
                     maxRecommendations: config.numOfTrendsItem ? parseInt(config.numOfTrendsItem) : algoliaConfig.recommend.limitTrendingItems,
+                    transformItems:function (items) {
+                        return items.map((item, index) => ({
+                            ...item,
+                            position: index + 1,
+                        }));
+                    },
                     headerComponent({html}) {
                         return recommendProductsHtml.getHeaderHtml(html,algoliaConfig.recommend.trendingItemsTitle);
                     },

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function execute(Observer $observer)`
`31`	`31`	`/** @var Customer $customer */`
`32`	`32`	`$customer = $observer->getEvent()->getCustomer();`
`33`	`33`
`34`		`- if ($this->insightsHelper->getPersonalizationHelper()->isPersoEnabled($customer->getStoreId())) {`
	`34`	`+ if ($this->insightsHelper->getConfigHelper()->isClickConversionAnalyticsEnabled($customer->getStoreId()) \|\| $this->insightsHelper->getPersonalizationHelper()->isPersoEnabled($customer->getStoreId())) {`
`35`	`35`	`$this->insightsHelper->setUserToken($customer);`
`36`	`36`	`}`
`37`	`37`	`}`