MAGE-1044 Test sorting attribute via ConfigHelper

Author: cammonro

Test/Integration/Product/ReplicaIndexingTest.php

@@ -10,14 +10,14 @@
 
 class ReplicaIndexingTest extends IndexingTestCase
 {
-    protected ?ReplicaManagerInterface $replicaManager;
-    protected ?ProductIndexer $productIndexer;
+    protected ?ReplicaManagerInterface $replicaManager = null;
+    protected ?ProductIndexer $productIndexer = null;
 
-    protected ?IndicesConfigurator $indicesConfigurator;
+    protected ?IndicesConfigurator $indicesConfigurator = null;
 
-    protected ?string $indexSuffix;
+    protected ?string $indexSuffix = null;
 
-    protected ?array $ogSortingState;
+    protected ?array $ogSortingState = null;
 
     public function setUp(): void
     {
@@ -107,6 +107,7 @@ function($replica) use ($sortIndexName) {
 
     /**
      * @magentoDbIsolation disabled
+     * @group virtual
      */
     public function testVirtualReplicaConfig(): void
     {
@@ -124,33 +125,13 @@ public function testVirtualReplicaConfig(): void
             'sort' => $sortDir,
             'sortLabel' => $sortAttr
         ];
-        $encoded = json_encode($sorting);
-//        $this->setConfig('algoliasearch_instant/instant_sorts/sorts', $encoded);
         $this->configHelper->setSorting($sorting);
 
-        $connection = $this->objectManager->create(\Magento\Framework\App\ResourceConnection::class)
-            ->getConnection();
-//        $connection->beginTransaction();
-//        $this->objectManager->get(\Magento\Framework\App\Config\Storage\WriterInterface::class)->save(
-//            \Algolia\AlgoliaSearch\Helper\ConfigHelper::SORTING_INDICES,
-//            $encoded,
-//            'default'
-//        );
-//        $connection->commit();
+        $this->assertConfigInDb('algoliasearch_instant/instant_sorts/sorts', json_encode($sorting));
 
+        $this->refreshConfigFromDb();
 
-        $select = $connection->select()
-            ->from('core_config_data', 'value')
-            ->where('path = ?', 'algoliasearch_instant/instant_sorts/sorts')
-            ->where('scope = ?', 'default')
-            ->where('scope_id = ?', 0);
-
-        $configValue = $connection->fetchOne($select);
-
-        // Assert that the correct value was written to the database
-        $this->assertEquals($encoded, $configValue);
-
-//        $this->assertSortingAttribute($sortAttr, $sortDir);
+        $this->assertSortingAttribute($sortAttr, $sortDir);
 
     }
 

Test/Integration/TestCase.php

@@ -8,6 +8,7 @@
 use Algolia\AlgoliaSearch\Setup\Patch\Schema\ConfigPatch;
 use Algolia\AlgoliaSearch\Test\Integration\AssertValues\Magento246;
 use Algolia\AlgoliaSearch\Test\Integration\AssertValues\Magento247;
+use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\App\ProductMetadataInterface;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Store\Model\ScopeInterface;
@@ -78,6 +79,32 @@ protected function setConfig(
         );
     }
 
+    protected function assertConfigInDb(
+        string $path,
+        mixed  $value,
+        string $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT,
+        int    $scopeId = 0
+    ): void
+    {
+        $connection = $this->objectManager->create(\Magento\Framework\App\ResourceConnection::class)
+            ->getConnection();
+
+        $select = $connection->select()
+            ->from('core_config_data', 'value')
+            ->where('path = ?', $path)
+            ->where('scope = ?', $scope)
+            ->where('scope_id = ?', $scopeId);
+
+        $configValue = $connection->fetchOne($select);
+
+        $this->assertEquals($value, $configValue);
+    }
+
+    protected function refreshConfigFromDb(): void
+    {
+        $this->objectManager->get(\Magento\Framework\App\Config\ReinitableConfigInterface::class)->reinit();
+    }
+
     protected function clearIndices()
     {
         $indices = $this->algoliaHelper->listIndexes();
@@ -107,7 +134,7 @@ private function bootstrap()
             return;
         }
 
-        $this->objectManager = Bootstrap::getObjectManager();
+        $this->objectManager = $this->getObjectManager();
 
         if (version_compare($this->getMagentoVersion(), '2.4.7', '<')) {
             $this->assertValues = new Magento246();