Merge pull request #1658 from algolia/fix/MAGE-1153-duplicate-synonyms

MAGE-1153 additional synonym use cases

Author: damcou

Helper/AlgoliaHelper.php

@@ -371,12 +371,6 @@ public function mergeSettings($indexName, $settings, string $mergeSettingsFrom =
         } catch (Exception $e) {
         }
 
-        $removes = ['slaves', 'replicas', 'decompoundedAttributes', 'synonyms'];
-
-        if (isset($onlineSettings['mode']) && $onlineSettings['mode'] == 'neuralSearch') {
-            $removes[] = 'mode';
-        }
-
         if (isset($settings['attributesToIndex'])) {
             $settings['searchableAttributes'] = $settings['attributesToIndex'];
             unset($settings['attributesToIndex']);
@@ -387,7 +381,7 @@ public function mergeSettings($indexName, $settings, string $mergeSettingsFrom =
             unset($onlineSettings['attributesToIndex']);
         }
 
-        foreach ($removes as $remove) {
+        foreach ($this->getSettingsToRemove($onlineSettings) as $remove) {
             if (isset($onlineSettings[$remove])) {
                 unset($onlineSettings[$remove]);
             }
@@ -400,6 +394,34 @@ public function mergeSettings($indexName, $settings, string $mergeSettingsFrom =
         return $onlineSettings;
     }
 
+    /**
+     * These settings are to be managed by other processes
+     * @param string[] $onlineSettings
+     * @return string[]
+     */
+    protected function getSettingsToRemove(array $onlineSettings): array
+    {
+        $removals = ['slaves', 'replicas', 'decompoundedAttributes'];
+
+        if (isset($onlineSettings['mode']) && $onlineSettings['mode'] == 'neuralSearch') {
+            $removals[] = 'mode';
+        }
+
+        return array_merge($removals, $this->getSynonymSettingNames());
+    }
+
+    /**
+     * @return string[]
+     */
+    protected function getSynonymSettingNames(): array
+    {
+        return [
+            'synonyms',
+            'altCorrections',
+            'placeholders'
+        ];
+    }
+
     /**
      * Legacy function signature to add objects to Algolia
      * @param array $objects