Fix product getUrl method by aligning with Magento core behavior #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the UrlRewrite::REDIRECT_TYPE => 0 parameter to the Algolia product URL filter data, ensuring that only non-redirect URL rewrites are considered when generating product URLs. This aligns the Algolia URL generation with Magento's core URL handling behavior and prevents potential issues with redirect loops or incorrect URL generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the UrlRewrite::REDIRECT_TYPE => 0 parameter to the product URL filter data, ensuring that only non-redirect URL rewrites are considered when generating product URLs.
This aligns the Algolia URL generation with Magento's core URL handling behavior and prevents potential issues with redirect loops or incorrect URL generation.
Adding filter redirect_type = 0
This parameter is important because: in the core Magento Catalog/Model/Product/Url.php class, it is included in the filter data, but it's missing in the Algolia extension's version.
Without this parameter, the URL finder might return redirect URLs instead of direct URLs, which could lead to redirect chains or incorrect URL generation.