feat(swift): add disjunctive faceting #3778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
reviewed
Sep 19, 2024
clients/algoliasearch-client-swift/Sources/Search/Extra/SearchQueryExtension.swift
Show resolved
Hide resolved
clients/algoliasearch-client-swift/Sources/Search/Extra/SearchClientExtension.swift
Show resolved
Hide resolved
clients/algoliasearch-client-swift/Sources/Search/Extra/DisjunctiveFaceting.swift
Show resolved
Hide resolved
| var localizedDescription: String { | ||
| switch self { | ||
| case .emptyResponses: | ||
| return "Unexpected empty search responses list. At least one search responses might be present." |
There was a problem hiding this comment.
wouldn't this be caught by the transporter? I'm not sure it's possible to have 0 responses
shortcuts
approved these changes
Sep 19, 2024
clients/algoliasearch-client-swift/Sources/Search/Extra/DisjunctiveFaceting.swift
Show resolved
Hide resolved
algolia-bot
added a commit
that referenced
this pull request
Sep 19, 2024
Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Sep 19, 2024
algolia/api-clients-automation#3778 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: DI-2852
Changes included:
🧪 Test
Unit tests imported from working v8