Skip to content

Conversation

@gazconroy
Copy link
Contributor

🧭 What and Why

As a follow-up to PR-3898-Correct typos in Search API, this PR looks at typos in the other specs.

Changes included:

  • Fixing some typos in the API descriptions

@gazconroy gazconroy requested a review from a team as a code owner October 9, 2024 10:39
@gazconroy gazconroy requested review from kai687, millotp and shortcuts and removed request for millotp and shortcuts October 9, 2024 10:39
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 9, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 03540015787d0fa94631279e285cc012918e75b6
🍃 Generated commit 9d9242d986f076eb8892396e462f87d6dd25cc04
🌲 Generated branch generated/fix/api-typos
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1697
php 1568
go 1551
csharp 1371
java 1106
python 1042
ruby 901
swift 768

@gazconroy gazconroy requested review from millotp and shortcuts October 9, 2024 10:40
kai687
kai687 previously approved these changes Oct 9, 2024
shortcuts
shortcuts previously approved these changes Oct 9, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for doing this!

@shortcuts shortcuts enabled auto-merge (squash) October 9, 2024 11:18
@millotp millotp disabled auto-merge October 9, 2024 11:29
@shortcuts shortcuts enabled auto-merge (squash) October 9, 2024 14:55
@shortcuts shortcuts dismissed stale reviews from kai687 and themself via c99b8b2 October 9, 2024 15:57
@shortcuts shortcuts merged commit f516d02 into main Oct 9, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/api-typos branch October 9, 2024 16:16
algolia-bot added a commit that referenced this pull request Oct 9, 2024
Co-authored-by: gazconroy <[email protected]>
Co-authored-by: Gary Conroy <[email protected]>
Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants