chore(scripts): allow variadic compilation for javascript #3933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
millotp
reviewed
Oct 9, 2024
scripts/buildLanguages.ts
Outdated
| return map; | ||
| } | ||
|
|
||
| // there is no monitoring client for now |
Member
Author
There was a problem hiding this comment.
ah yes it's not needed anymore it was just missing the dart guides case I think
Collaborator
|
gg |
Member
Author
cimr frr |
shortcuts
deleted the
chore/allow-variadic-compilation-js-playground-snippets-guides
branch
algolia-bot
added a commit
that referenced
this pull request
Oct 9, 2024
…nerated) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3033
Changes included:
this pr updates the build script to allow variadic client compilation on the javascript client, since this is the only fully variadic client.
not sure if it breaks other things, will see with the CI
example: https://github.com/algolia/api-clients-automation/actions/runs/11253862443/job/31290141181?pr=3932 -- the ci runs only for a subset of clients, but we ask for every playground/snippets/guides to be compiled, since it requires the client to be compiled too, this would fail