Skip to content

fix(specs): correct type for banners [skip-bc] #3939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2024
Merged

fix(specs): correct type for banners [skip-bc] #3939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4250dfb
fix(specs): correct type for banners
millotp Oct 9, 2024
ce7c589
banners alias to an array
millotp Oct 9, 2024
f92504a
Merge branch 'main' into fix/banner-link
millotp Oct 10, 2024
fcd1161
Merge branch 'main' into fix/banner-link
millotp Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ public class AlgoliaSwiftGenerator extends Swift5ClientCodegen {
"bannerimage",
"bannerimageurl",
"bannerlink",
"banners",
"baseindexsettings",
"basesearchparams",
"basesearchparamswithoutquery",
Expand Down
11 changes: 6 additions & 5 deletions specs/common/schemas/IndexSettings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,9 +1036,8 @@ banners:
description: banners defined in the merchandising studio for the given search.
type: array
additionalProperties: false
properties:
banners:
$ref: '#/banner'
items:
$ref: '#/banner'

banner:
description: a search banner with image and url.
Expand All @@ -1064,13 +1063,15 @@ bannerImage:
additionalProperties: false
properties:
urls:
$ref: '#/bannerImageUrl'
type: array
items:
$ref: '#/bannerImageUrl'
title:
type: string

bannerImageUrl:
description: url for a search banner image.
type: array
type: object
additionalProperties: false
properties:
url:
Expand Down
2 changes: 0 additions & 2 deletions templates/javascript/clients/algoliasearch/builds/models.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import type {
BannerImage,
BannerImageUrl,
BannerLink,
Banners,
BaseIndexSettings,
BaseSearchParams,
BaseSearchParamsWithoutQuery,
Expand Down Expand Up @@ -112,7 +111,6 @@ export {
BannerImage,
BannerImageUrl,
BannerLink,
Banners,
BaseIndexSettings,
BaseSearchParams,
BaseSearchParamsWithoutQuery,
Expand Down
Loading