Skip to content

Conversation

@shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 17, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2881

Changes included:

  • remove parentID from ingestion specs
  • fix the generated commit logic

@shortcuts shortcuts self-assigned this Oct 17, 2024
@shortcuts shortcuts requested a review from a team as a code owner October 17, 2024 11:21
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 17, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 046cca7578ed99a4fcced10d646b5a8a72229ea8
🍃 Generated commit 133d88aa3cfe0273847a86a4385cd26bb24e3977
🌲 Generated branch generated/fix/gen-commit
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1670
go 1654
php 1426
csharp 1384
java 1122
python 1024
ruby 883
swift 752

@shortcuts shortcuts changed the title fix(specs): remove parentID from ingestion specs fix(specs): remove parentID from ingestion specs [skip-bc] Oct 17, 2024
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@shortcuts shortcuts enabled auto-merge (squash) October 17, 2024 11:42
@shortcuts shortcuts merged commit 451bf71 into main Oct 17, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/gen-commit branch October 17, 2024 11:50
algolia-bot added a commit that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 17, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 17, 2024
shortcuts added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants