Skip to content

fix(specs): method names in breaking changes table #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix(specs): method names in breaking changes table #4010

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65bd97b
fix: method names
kai687 Oct 21, 2024
4c03a34
Merge branch 'main' into fix/version-table
kai687 Oct 21, 2024
98c4652
Merge branch 'main' into fix/version-table
shortcuts Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions specs/major-breaking-changes-rename.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"client.getFrequentlyBoughtTogether": "client.getRecommendations",
"client.getLookingSimilar": "client.getRecommendations",
"client.getRecommendations": "client.getRecommendations",
"client.getRecommendedForYou": "client.getRecommendations",
Copy link
Member

@shortcuts shortcuts Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this existed in the javascript v4 client, no? @kai687

Copy link
Contributor Author

@kai687 kai687 Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't documented publicly, so I thought we can just not include this.

"client.getRelatedProducts": "client.getRecommendations",
"client.getTrendingFacets": "client.getRecommendations",
"client.getTrendingItems": "client.getRecommendations"
Expand Down Expand Up @@ -49,15 +48,14 @@
"index.browseSynonyms": "client.browseSynonyms",
"index.clearObjects": "client.clearObjects",
"index.clearRules": "client.clearRules",
"index.clearSynonyms": "client.clearAllSynonyms",
"index.clearSynonyms": "client.clearSynonyms",
"index.copySettings": "client.operationIndex",
"index.delete": "client.deleteIndex",
"index.deleteBy": "client.deleteBy",
"index.deleteObject": "client.deleteObject",
"index.deleteObjects": "client.deleteObjects",
"index.deleteRule": "client.deleteRule",
"index.deleteSynonym": "client.deleteSynonym",
"index.exists": "client.indexExists",
"index.findObject": "client.searchSingleIndex",
"index.getObject": "client.getObject",
"index.getObjects": "client.getObjects",
Expand All @@ -77,7 +75,7 @@
"index.saveSynonym": "client.saveSynonym",
"index.saveSynonyms": "client.saveSynonyms",
"index.search": "client.searchSingleIndex",
"index.searchForFacetValues": "client.searchForFacets",
"index.searchForFacetValues": "client.searchForFacetValues",
"index.searchRules": "client.searchRules",
"index.searchSynonyms": "client.searchSynonyms",
"index.setSettings": "client.setSettings",
Expand Down
Loading