-
Notifications
You must be signed in to change notification settings - Fork 27
guides: add pushSetup for ingestion API #4126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
| "pushSetup": { | ||
| "method": "pushTask", | ||
| "parameters": { | ||
| "taskID": "YOUR_TASK_ID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this will be replaced by the correct taskID on the dashboard ! cc @morganleroi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same!!
649d298 to
af6612a
Compare
millotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry
| // special lambda for dynamic templates | ||
| bundle.put("dynamicTemplate", new DynamicTemplateLambda(this)); | ||
| bundle.put("dynamicSnippet", new DynamicSnippetLambda(this, models, operations, language, client)); | ||
| if (new File("tests/CTS/guides/" + client + ".json").exists()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be done inside of the lambda directly to avoid leaking the internal logic here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's always called I wanted to avoid no-op as it's less explicit when looking at this file, idk what you prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this files makes it harder since now the path is in multiple files rather than just the lambda, this file should be more generic IMO
| } | ||
|
|
||
| // use runID in the Observability debugger | ||
| fmt.Println("run", run.RunID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or main run id soon !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😶 shhhhh
millotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg !
| {{> snippets/import}} | ||
|
|
||
| using Action = Algolia.Search.Models.Ingestion.Action; | ||
| using PushTaskRecords = Algolia.Search.Models.Ingestion.PushTaskRecords; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| using PushTaskRecords = Algolia.Search.Models.Ingestion.PushTaskRecords; | |
| using Algolia.Search.Models.Ingestion.PushTaskRecords; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this aliases automatically? nice
millotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful !
Co-authored-by: Clément Vannicatte <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3199
Changes included:
add a simple push snippet for the end of the setup on the dashboard