Skip to content

Conversation

@Fluf22
Copy link
Collaborator

@Fluf22 Fluf22 commented Nov 19, 2024

🧭 What and Why

🎟 JIRA Ticket: -
fixes algolia/algoliasearch-client-swift#785

Changes included:

  • Put Task and LogLevel in the reserved model names

@Fluf22 Fluf22 requested a review from a team as a code owner November 19, 2024 10:55
@Fluf22 Fluf22 self-assigned this Nov 19, 2024
@Fluf22 Fluf22 requested a review from shortcuts November 19, 2024 10:55
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 19, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 6c31006398e3c90e3fcfc300e0c17e55228f1bae
🍃 Generated commit d92589ad0d3485208421848856f85ea67e22b2c6
🌲 Generated branch generated/fix/swift-model-conflict
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1675
javascript 1636
php 1527
csharp 1189
java 1143
python 1075
ruby 868
swift 751

@Fluf22 Fluf22 changed the title fix(swift): conflict between Swift native models and api client ones fix(swift): prefix Task and LogLevel models with the client names Nov 19, 2024
@Fluf22 Fluf22 enabled auto-merge (squash) November 19, 2024 11:07
@Fluf22 Fluf22 merged commit 989a727 into main Nov 19, 2024
29 checks passed
@Fluf22 Fluf22 deleted the fix/swift-model-conflict branch November 19, 2024 11:13
algolia-bot added a commit that referenced this pull request Nov 19, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naming clash with Swift's Task

5 participants