Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented Jan 15, 2025

🧭 What and Why

It's very annoying to add [skip-bc] to all PR because we slowed down our release cycle.
Now it will only be a warning in the sticky comment.

@millotp millotp requested a review from a team as a code owner January 15, 2025 16:38
@millotp millotp requested review from Fluf22 and morganleroi January 15, 2025 16:38
@millotp millotp self-assigned this Jan 15, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 15, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 7337e1a3418538c9e4d047c26d3ed5cc73f79e75
🍃 Generated commit 381125206455d35b42b13edfde987a396433e066
🌲 Generated branch generated/chore/annoying-skip-bc
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1675
go 1675
php 1492
csharp 1436
java 1121
python 1100
ruby 849
swift 759

Fluf22
Fluf22 previously approved these changes Jan 15, 2025
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankyou.gif

Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@millotp millotp merged commit f63a9c8 into main Jan 16, 2025
28 checks passed
@millotp millotp deleted the chore/annoying-skip-bc branch January 16, 2025 09:40
algolia-bot added a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants