feat(specs): detail perso error codes [PRED-3384] #4413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
|
bengreenbank
changed the title
bengreenbank
changed the title
| @@ -1,5 +1,17 @@ | |||
| description: Invalid user ID format. | |||
| description: Invalid user token. | |||
Contributor
There was a problem hiding this comment.
Any reasons we're using "user token" and not "user ID" here?
Contributor
Author
There was a problem hiding this comment.
I missed that - it should be like you suggest f543bd5
bengreenbank
force-pushed
the
feat/adv-perso/error-codes-pred-3384
branch
from
19b79aa to
102748a
Compare
bengreenbank
requested review from
a team,
Fluf22 and
morganleroi
and removed request for
a team
francoischalifour
approved these changes
Jan 29, 2025
Contributor
Author
|
We're good to merge, thanks @millotp! |
algolia-bot
added a commit
that referenced
this pull request
Jan 29, 2025
… [skip ci] Co-authored-by: Ben Greenbank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Instead of using the generic base response (see below), we detail the exact error message that is expected for each response.
🎟 JIRA Ticket: PRED-3384
Changes included:
🧪 Test