Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented Jan 30, 2025

🧭 What and Why

🎟 JIRA Ticket: DI-3448

fixes algolia/algoliasearch-client-php#747

@millotp millotp requested a review from a team as a code owner January 30, 2025 10:18
@millotp millotp requested review from Fluf22 and morganleroi January 30, 2025 10:18
@millotp millotp self-assigned this Jan 30, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 30, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 74604577e5a75d8164b3ef6fe7a23da8b3d7052d
🍃 Generated commit 1d919f8334eb93788c9fa896e4d46e2f55fefec2
🌲 Generated branch generated/fix/php-compat
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
php 1507

Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP is weird

@millotp millotp merged commit 437c993 into main Jan 30, 2025
16 checks passed
@millotp millotp deleted the fix/php-compat branch January 30, 2025 10:27
algolia-bot added a commit that referenced this pull request Jan 30, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 30, 2025
@nadar
Copy link

nadar commented Mar 1, 2025

If someone else is confused about the Composer constraint, it's really just version 8.3.0. If you have 8.3.1, it works perfectly. I saw a few platform overrides that mostly do this, which will fail:

 "config": {
    "platform": {
      "php": "8.3",
    },
  },

Then you have to explicitly set another patch version, like:

"config": {
   "platform": {
     "php": "8.3.15",
   },
 },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: incompatible with php 8.3.0

5 participants