Skip to content

fix(specs): allow search params as object for sffv #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix(specs): allow search params as object for sffv #4418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc9b28b
fix(specs): allow search params as object for sffv
kai687 Jan 31, 2025
5f8793f
fix: add cts for new option
kai687 Jan 31, 2025
4923525
fix: needs another definition
kai687 Jan 31, 2025
03ee134
Merge branch 'main' into feat/sffv-param-object
kai687 Mar 12, 2025
2490857
Merge branch 'main' into feat/sffv-param-object
kai687 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/search/paths/search/searchForFacetValues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ post:
additionalProperties: false
properties:
params:
$ref: '../../../common/schemas/SearchParams.yml#/paramsAsString'
$ref: '../../../common/schemas/SearchParams.yml#/searchParams'
facetQuery:
$ref: '../../common/schemas/SearchQuery.yml#/facetQuery'
maxFacetHits:
Expand Down
27 changes: 26 additions & 1 deletion tests/CTS/requests/search/searchForFacetValues.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
}
},
{
"testName": "get searchForFacetValues results with all parameters",
"testName": "get searchForFacetValues results with all parameters as string",
"parameters": {
"indexName": "indexName",
"facetName": "facetName",
Expand All @@ -31,6 +31,31 @@
}
}
},
{
"testName": "get searchForFacetValues results with all parameters as object",
"parameters": {
"indexName": "indexName",
"facetName": "facetName",
"searchForFacetValuesRequest": {
"params": {
"facetFilters": ["bar"]
},
"facetQuery": "foo",
"maxFacetHits": 42
}
},
"request": {
"path": "/1/indexes/indexName/facets/facetName/query",
"method": "POST",
"body": {
"params": {
"facetFilters": ["bar"]
},
"facetQuery": "foo",
"maxFacetHits": 42
}
}
},
{
"testName": "facetName and facetQuery",
"parameters": {
Expand Down
Loading