Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented Mar 5, 2025

🧭 What and Why

The improvements thanks to only running client that has changes is dwarfed by swift being so slow, we don't need this anymore.
And it's causing issues with guides because they are not in 1 folder by client

@millotp millotp requested a review from a team as a code owner March 5, 2025 16:29
@millotp millotp requested review from Fluf22 and shortcuts March 5, 2025 16:29
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 5, 2025

✔️ Code generated!

Name Link
🪓 Triggered by c30558b80a01770dd749412ac6cfb9bfc1abda55
🍃 Generated commit 97b52acab6312e03bae395a22610ba34151b26f6
🌲 Generated branch generated/chore/run-all
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1616
go 1609
php 1476
csharp 1328
python 1096
java 1084
ruby 814
swift 483
scala 23

@shortcuts
Copy link
Member

Wonderful, however how comes it doesn't show the ingestion snippets in the diff? They should've been re-generated, no?

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all thanks swift for being slow

@millotp millotp merged commit b154bda into main Mar 6, 2025
28 checks passed
@millotp millotp deleted the chore/run-all branch March 6, 2025 16:31
algolia-bot added a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants