Skip to content

fix(python): npe in request options merge method #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix(python): npe in request options merge method #4612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clients/algoliasearch-client-python/algoliasearch/http/request_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ def merge(
_user_request_options = user_request_options

for key, value in _user_request_options.items():
request_options[key].update(value)
if request_options[key] is None:
Copy link
Member

@shortcuts shortcuts Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L68 there's a default for the None parameters, maybe do the same for data?

Copy link
Collaborator Author

@Fluf22 Fluf22 Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitant because in other languages, if there are data set in the request options, we overwrite the original object.
It's not the case in python (yet), but I thought it was more safe to handle it carefully that way, to prevent any misbehaviour if we make the code more consistent with the other languages in the future

Copy link
Member

@shortcuts shortcuts Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we will go to that level of consistency honestly it seems too much but your solution works as well so i'm good with it!

request_options[key] = value
else:
request_options[key].update(value)

return self.from_dict(request_options)