feat(clients): add new realtime-personalization api #4613
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| strategy: | ||
| type: string | ||
| enum: | ||
| - session | ||
| - hybrid | ||
| example: 'session' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| user: | ||
| type: object | ||
| additionalProperties: false | ||
| required: | ||
| - version | ||
| - userID | ||
| - search | ||
| properties: | ||
| version: | ||
| type: string | ||
| description: Version of the response format. | ||
| userID: | ||
| type: string | ||
| description: User ID of the user. | ||
| search: | ||
| type: object | ||
| description: | | ||
| Index personalization filters by index name. | ||
| additionalProperties: | ||
| $ref: '#/searchFilters' | ||
|
|
||
| searchFilters: | ||
| type: object | ||
| additionalProperties: false | ||
| properties: | ||
| indices: | ||
| type: array | ||
| items: | ||
| type: string | ||
| example: ['storefront', 'storefront_price_asc', 'storefront_price_desc'] | ||
| strategy: | ||
| $ref: '../enums.yml#/strategy' | ||
| filters: | ||
| $ref: '#/searchFilter' | ||
|
|
||
| searchFilter: | ||
| type: object | ||
| additionalProperties: false | ||
| properties: | ||
| session: | ||
| type: array | ||
| items: | ||
| type: string | ||
| example: ['brand:Dyson<score=12>'] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this allow us to store search configurations for multiple groups of indices, and have a dynamic name?
Example extracted from Francois' presentation:
Not sure how we represent that in the spec though.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attribute
additionalPropertiesallows us to tell the generator that the key of the object can be dynamic but that the format of the value should be of typesearchFilters.I'm not fond of this method but we don't have too much choice to respect the response we want.
We could still challenge the response format to replace the objects by arrays which would make the specs clearer imo like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current specs the generated exemples looks like this :
{ "version": "string", "userID": "string", "search": { "additionalProp1": { "indices": [ "storefront", "storefront_price_asc", "storefront_price_desc" ], "strategy": "session", "filters": { "session": [ "brand:Dyson<score=12>" ], "additionalProp1": {} }, "additionalProp1": {} }, "additionalProp2": { "indices": [ "storefront", "storefront_price_asc", "storefront_price_desc" ], "strategy": "session", "filters": { "session": [ "brand:Dyson<score=12>" ], "additionalProp1": {} }, "additionalProp1": {} }, "additionalProp3": { "indices": [ "storefront", "storefront_price_asc", "storefront_price_desc" ], "strategy": "session", "filters": { "session": [ "brand:Dyson<score=12>" ], "additionalProp1": {} }, "additionalProp1": {} } }, "additionalProp1": {} }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the reason for this structure was so that the FE could retrieve the required attributes as quick as possible (it's more time consuming to filter an array based on a key than it is to get a specific key from a map).
This looks good for now, but if it causes issues we can rethink it