fix(clients): InvalidOperationException in C# Fill() due to unsafe dictionary enumeration #4820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
changed the title
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
May 12, 2025
…ctionary enumeration (generated) algolia/api-clients-automation#4820 Co-authored-by: Renée Mundie <[email protected]> Co-authored-by: Renee Mundie <[email protected]> Co-authored-by: Morgan Leroi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Fixes a concurrency issue in the generated C# client (HttpRequestHeadersExtensions.Fill) where a shared IDictionary<string, string> is enumerated without being cloned. This causes intermittent InvalidOperationException under load when the collection is modified during enumeration.
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3456
Changes included:
🧪 Test