Skip to content

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 2, 2025

🧭 What and Why

Some parameters deserve to be generic, to make it easier for the user.
Starting with saveObject.

This is similar to a previous attempt a long time ago: #3151

@millotp millotp self-assigned this Jun 2, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 2, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 1602ff38caa3742f67d2add4d07f3aa810f269c3
🍃 Generated commit 682034674359f863e2ede7b472821895b33d1493
🌲 Generated branch generated/feat/generic-param
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1759
javascript 1655
php 1460
csharp 1251
python 1095
java 1071
ruby 801
swift 424
scala 23

@millotp millotp marked this pull request as ready for review June 3, 2025 12:20
@millotp millotp requested a review from a team as a code owner June 3, 2025 12:20
@millotp millotp requested review from Fluf22 and morganleroi June 3, 2025 12:20
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice

@millotp millotp enabled auto-merge (squash) June 3, 2025 14:08
@millotp millotp merged commit aa5c34c into main Jun 3, 2025
28 checks passed
@millotp millotp deleted the feat/generic-param branch June 3, 2025 14:25
algolia-bot added a commit that referenced this pull request Jun 3, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants