Skip to content

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 4, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3883

Changes included:

generate tests for the new helpers, as well as forwarding the hosts to the config for the python and go client (cc @millotp you were right this was needed ahah)

@shortcuts shortcuts self-assigned this Jun 4, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 4, 2025

✔️ Code generated!

Name Link
🪓 Triggered by d15388e9789c647ee3c2213a42f3991fdce864a5
🍃 Generated commit 4bf14a9d5626b342bb79885f48bba1408e4b9fe3
🌲 Generated branch generated/chore/generate-with-transformation-tests
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1762
javascript 1620
php 1482
csharp 1248
java 1082
python 1068
ruby 821
swift 455
scala 23

@shortcuts shortcuts force-pushed the chore/generate-with-transformation-tests branch 3 times, most recently from 0e9e902 to 2a26c91 Compare June 4, 2025 14:53
Base automatically changed from feat/specs-with-transformation-helpers to main June 4, 2025 15:00
@shortcuts shortcuts force-pushed the chore/generate-with-transformation-tests branch from 4a7a06f to 1e50912 Compare June 4, 2025 19:47
@shortcuts shortcuts marked this pull request as ready for review June 4, 2025 20:56
@shortcuts shortcuts requested a review from a team as a code owner June 4, 2025 20:56
@shortcuts shortcuts requested review from millotp and morganleroi June 4, 2025 20:56
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@shortcuts shortcuts merged commit 883b38a into main Jun 5, 2025
29 checks passed
@shortcuts shortcuts deleted the chore/generate-with-transformation-tests branch June 5, 2025 06:17
algolia-bot added a commit that referenced this pull request Jun 5, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jun 5, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants