Skip to content

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

seems like we have an issue on our metis app which prevents this e2e from running, we can skip it for now

@shortcuts shortcuts self-assigned this Jun 11, 2025
@shortcuts shortcuts requested a review from a team as a code owner June 11, 2025 10:25
@shortcuts shortcuts requested review from Fluf22 and morganleroi June 11, 2025 10:25
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 11, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 7423f1eaacdda557354450e895fa26c1f7cd597d
🍃 Generated commit 346608b324473feebe6e1704c9d7c6b3d9df3c58
🌲 Generated branch generated/chore/skip-composition
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1792
javascript 1650
php 1506
csharp 1312
python 1066
java 1037
swift 815
ruby 813
scala 23

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: do you think it would be hard to implement a skip boolean in the test spec? 😬
Instead of fully removing the test

Otherwise tell me and I'll approve that
I'm just afraid we won't ever put it back

@shortcuts
Copy link
Member Author

qq: do you think it would be hard to implement a skip boolean in the test spec? 😬 Instead of fully removing the test

Otherwise tell me and I'll approve that I'm just afraid we won't ever put it back

I wanted to go with that first but then realized it would be something we might overuse for simplicity/easier for anyone to toggle so... I've went with removing and will add it back 🥶

@shortcuts shortcuts merged commit b05d86d into main Jun 11, 2025
28 checks passed
@shortcuts shortcuts deleted the chore/skip-composition branch June 11, 2025 11:24
algolia-bot added a commit that referenced this pull request Jun 11, 2025
millotp added a commit that referenced this pull request Jun 14, 2025
algolia-bot added a commit that referenced this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants