Skip to content

Conversation

@ClaraMuller
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: Work preparation for https://algolia.atlassian.net/browse/CMP-484

Composition API team is preparing update of the API clients with writes endpoints (see full list of endpoints here).
Goals of this PR is to cleanup / refactor the current Open API spec to ease the integrations of the new endpoints.

Changes included:

  • For naming convention consistency Following files have been renamed to match (start with upper case)

    • specs/composition-full/common/schemas/BatchCompositionAction.yml
    • specs/composition-full/common/schemas/CompositionBehavior.yml
    • specs/composition-full/common/schemas/CompositionBehavior.yml
    • specs/composition-full/common/schemas/ListCompositionsResponse.yml
    • specs/composition-full/common/schemas/RulesBatchCompositionAction.yml
    • specs/composition-full/common/schemas/CompositionRule.yml
  • Extract struct Composition from ListCompositionsResponse.yml to specs/composition-full/common/schemas/Composition.yml to make it reusable in a wider context.

  • Fix incorrect input in CompositionRule.yml

  • Fix typos in SearchParams.yml

🧪 Test

  • CI
  • Locally run
    • yarn cli build specs all
    • yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team as a code owner July 15, 2025 14:00
@ClaraMuller ClaraMuller requested review from millotp and shortcuts July 15, 2025 14:00
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 15, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 3c905a50dc1f549556a484160f96a743a649c596
🍃 Generated commit cf82d464cfbc91a49ff86df21bda62c355ce37cb
🌲 Generated branch generated/clara/refact/composition-private-client
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1782
javascript 1642
php 1489
csharp 1296
java 1104
python 1072
ruby 799
swift 730
scala 23

@ClaraMuller ClaraMuller force-pushed the clara/refact/composition-private-client branch from c84a624 to a540f5d Compare July 15, 2025 14:02
@ClaraMuller ClaraMuller changed the title Clara/refact/composition private client fix(specs): cleanup for composition API clients Jul 15, 2025
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@shortcuts shortcuts merged commit 278a9e6 into main Jul 16, 2025
29 checks passed
@shortcuts shortcuts deleted the clara/refact/composition-private-client branch July 16, 2025 08:17
algolia-bot added a commit that referenced this pull request Jul 16, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants