fix(go): retry strategy #5159
Merged
fix(go): retry strategy #5159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
changed the title
|
|
||
| for _, h := range t.retryStrategy.GetTryableHosts(k) { | ||
| // Prepare the request to be retryable. | ||
| req, _ = prepareRetryableRequest(req) |
There was a problem hiding this comment.
It looks like we never use the returned error. Should we avoid returning the error then?
There was a problem hiding this comment.
we handle errors everywhere so I assume we can do it there as well, idk if this would lead to edge cases though
mehmetaligok
approved these changes
Jul 25, 2025
algolia-bot
added a commit
that referenced
this pull request
Jul 25, 2025
Co-authored-by: Clément Vannicatte <[email protected]> Co-authored-by: Antoine GILLES <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jul 25, 2025
algolia/api-clients-automation#5159 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]> Co-authored-by: Antoine GILLES <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-4068
Changes included:
closes #5158