Skip to content

fix(scala): prefix tags with v #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025
Merged

fix(scala): prefix tags with v #5186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fdac7d
fix(scala): release process
shortcuts Jul 30, 2025
f2159b9
checkout the tag
millotp Jul 30, 2025
662cb92
Merge branch 'main' into fix/scala-release
millotp Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions clients/algoliasearch-client-scala/.github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-tags: true

- name: checkout the release tag
run: |
TAG=$(sed -n 's/.*version := "\(.*\)"/\1/p' version.sbt)
echo "Checking out tag $TAG"
git checkout "v$TAG"

- name: Install Java
uses: actions/setup-java@v4
Expand All @@ -26,7 +34,7 @@ jobs:

- run: sbt ci-release
env:
PGP_PASSPHRASE: ${{ secrets.SIGNING_PRIVATE_KEY_PASSWORD }}
PGP_SECRET: ${{ secrets.SIGNING_PRIVATE_KEY }}
PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
PGP_SECRET: ${{ secrets.PGP_SECRET }}
SONATYPE_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
SONATYPE_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
2 changes: 1 addition & 1 deletion scripts/ci/codegen/spreadGeneration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ async function spreadGeneration(): Promise<void> {
// ruby tag is already pushed by `rake release`
if (IS_RELEASE_COMMIT && lang !== 'ruby') {
// Go needs a 'v' prefix for tags.
const tagVersion = lang === 'go' ? `v${version}` : version;
const tagVersion = lang === 'go' || lang === 'scala' ? `v${version}` : version;

console.log(`Processing release commit, creating new release tag ('${version}') for '${lang}' repository.`);

Expand Down