Skip to content

chore(scripts): allow retry of the release #5223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

chore(scripts): allow retry of the release #5223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,17 +693,29 @@
GITHUB_TOKEN: ${{ secrets.ALGOLIA_BOT_TOKEN }}

- name: Wait for all release CI
id: waitForAllReleases
run: yarn workspace scripts waitForAllReleases ${{ steps.spreadGeneration.outputs.PUSHED_LANGUAGES }}
env:
GITHUB_TOKEN: ${{ secrets.ALGOLIA_BOT_TOKEN }}

- name: Create GitHub release
run: yarn workspace scripts createGitHubReleases ${{ steps.spreadGeneration.outputs.PUSHED_LANGUAGES }}
run: yarn workspace scripts createGitHubReleases ${{ steps.waitForAllReleases.outputs.RELEASED_LANGUAGES }}
env:
GITHUB_TOKEN: ${{ secrets.ALGOLIA_BOT_TOKEN }}

- name: Push generated files to repositories
- name: Push generated files to doc/dashboard repositories
run: yarn workspace scripts pushToRepository
if: ${{ steps.waitForAllReleases.outputs.CAN_PUSH_TO_REPO == 'true' }}
env:
GH_TOKEN: ${{ secrets.ALGOLIA_BOT_TOKEN }}
GITHUB_TOKEN: ${{ secrets.ALGOLIA_BOT_TOKEN }}

- name: notify failures
uses: slackapi/[email protected]

Check warning on line 714 in .github/workflows/check.yml

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

.github/workflows/check.yml#L714 

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
if: ${{ steps.waitForAllReleases.outputs.FAILED_RELEASES != '' }}
with:
method: chat.postMessage
token: ${{ secrets.SLACK_BOT_TOKEN }}
payload: |
channel: ${{ secrets.SLACK_CHANNEL_ID }}
text: ":alert: Some clients failed to release :alert: \n${{ steps.waitForAllReleases.outputs.FAILED_RELEASES }}\nYou can retry the CI jobs to release them again, it will not affect already released clients."
8 changes: 6 additions & 2 deletions scripts/ci/codegen/spreadGeneration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ async function spreadGeneration(): Promise<void> {
if (IS_RELEASE_COMMIT) {
console.log('Creating new `released` tag for latest commit');
await run(`git tag ${await getNewReleasedTag()}`);
await run('git push --tags');
try {
await run('git push --tags');
} catch (e) {
console.error('Failed to push tags, it might already exist, ignoring error.', e);
}
}

const pushed: Language[] = [];
Expand All @@ -62,7 +66,7 @@ async function spreadGeneration(): Promise<void> {
const { tempGitDir } = await cloneRepository({
lang,
githubToken,
tempDir: process.env.RUNNER_TEMP!,
tempDir: process.env.RUNNER_TEMP || '/tmp',
});

const clientPath = toAbsolutePath(getLanguageFolder(lang));
Expand Down
7 changes: 6 additions & 1 deletion scripts/ci/codegen/waitForAllReleases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as core from '@actions/core';
import type { components } from '@octokit/openapi-types';

import { exists, getOctokit, run, setVerbose, toAbsolutePath } from '../../common.ts';
Expand Down Expand Up @@ -125,8 +126,12 @@ async function waitForAllReleases(languagesReleased: Language[]): Promise<void>
}

if (failures.length > 0) {
throw new Error(`${failures.join(', ')} failed to release`);
console.error(`${failures.join(', ')} releases failed, please check the CI logs.`);
core.setOutput('FAILED_RELEASES', failures.join(' '));
}

core.setOutput('CAN_PUSH_TO_REPO', true);
core.setOutput('RELEASED_LANGUAGES', languagesReleased.filter((lang) => !failures.includes(lang)).join(' '));
}

if (import.meta.url.endsWith(process.argv[1])) {
Expand Down