Skip to content

Conversation

@ben-kalmus
Copy link
Contributor

@ben-kalmus ben-kalmus commented Sep 30, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-539

Changes included:

  • Added deduplication.positioning setting to Composition Injection
  • Added Composition and Composition Rule tests
  • Added Composition Batch and Batch Rules tests

🧪 Test

CTS

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 30, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 54673a168b914d4eb97b136e1a70de41f693eb64
🍃 Generated commit 6d51c254a18d33e4ddb723d5fba4b6d32912dc8f
🌲 Generated branch generated/benk/add-deduplication-setting-field
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1777
javascript 1593
php 1490
csharp 1307
python 1162
java 998
ruby 833
swift 335
scala 23

@ben-kalmus ben-kalmus changed the title feat: add compositions deduplication setting feat(specs): add compositions deduplication setting Sep 30, 2025
@ben-kalmus ben-kalmus force-pushed the benk/add-deduplication-setting-field branch from e9cd1cc to 3d93cf1 Compare September 30, 2025 08:42
@ben-kalmus ben-kalmus force-pushed the benk/add-deduplication-setting-field branch from 6fea709 to e3cc3d5 Compare September 30, 2025 09:14
@ben-kalmus ben-kalmus force-pushed the benk/add-deduplication-setting-field branch 3 times, most recently from eecd9af to bcab941 Compare September 30, 2025 10:47
@ben-kalmus ben-kalmus force-pushed the benk/add-deduplication-setting-field branch from bcab941 to 0ea81d5 Compare September 30, 2025 10:55
@ben-kalmus ben-kalmus marked this pull request as ready for review September 30, 2025 11:49
@ben-kalmus ben-kalmus requested a review from a team as a code owner September 30, 2025 11:49
Copy link
Contributor

@ClaraMuller ClaraMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these updates are used in documentation.
I had feedback that these values are not clear.
See PR #5419

Co-authored-by: Clara Muller <[email protected]>
@ClaraMuller
Copy link
Contributor

@ben-kalmus Sorry I was asked to again modify the values for the key

@ben-kalmus
Copy link
Contributor Author

@ben-kalmus Sorry I was asked to again modify the values for the key

No problem, I renamed it to my-unique-injected-item-key

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! the generation looks good

@millotp millotp merged commit 7de9435 into main Oct 2, 2025
154 of 164 checks passed
@millotp millotp deleted the benk/add-deduplication-setting-field branch October 2, 2025 09:03
algolia-bot added a commit that referenced this pull request Oct 2, 2025
…d) [skip ci]

Co-authored-by: Ben Kalmus <[email protected]>
Co-authored-by: Clara Muller <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 2, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants