Skip to content

fix(clients): move default timeouts to the constructor #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2025
Merged

fix(clients): move default timeouts to the constructor #5443

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b047b0
fix(clients): move default timeouts to the constructor
millotp Oct 6, 2025
f2c3e97
Merge branch 'main' into fix/ruby-defaults
millotp Oct 6, 2025
128a802
Merge branch 'main' into fix/ruby-defaults
millotp Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions templates/ruby/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,18 @@ module {{moduleName}}
raise '`app_id` is missing.' if config.app_id.nil? || config.app_id == ''
raise '`api_key` is missing.' if config.api_key.nil? || config.api_key == ''

if config.connect_timeout.nil?
config.connect_timeout = {{x-timeouts.server.connect}}
end

if config.read_timeout.nil?
config.read_timeout = {{x-timeouts.server.read}}
end

if config.write_timeout.nil?
config.write_timeout = {{x-timeouts.server.write}}
end

@api_client = Algolia::ApiClient.new(config)
end

Expand Down Expand Up @@ -54,22 +66,10 @@ module {{moduleName}}
{{/hostsWithoutVariables.size}}

config = Algolia::Configuration.new(app_id, api_key, hosts, '{{{baseName}}}', opts)
create_with_config(config)
new(config)
end

def self.create_with_config(config)
if config.connect_timeout.nil?
config.connect_timeout = {{x-timeouts.server.connect}}
end

if config.read_timeout.nil?
config.read_timeout = {{x-timeouts.server.read}}
end

if config.write_timeout.nil?
config.write_timeout = {{x-timeouts.server.write}}
end

new(config)
end

Expand Down Expand Up @@ -196,4 +196,4 @@ module {{moduleName}}
{{/isSearchClient}}
end
{{/operations}}
end
end