Skip to content

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 14, 2025

🧭 What and Why

The >LOG marker was intended to be used internally only, but it leaked into the doc and it's not very nice to look at.

Screenshot 2025-10-15 at 00 01 28

Also harmonize the log for all languages.

@millotp millotp self-assigned this Oct 14, 2025
@millotp millotp requested a review from a team as a code owner October 14, 2025 22:03
@millotp millotp changed the title Fix/ugly log snippets: remove all the >LOG Oct 14, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 14, 2025

✔️ Code generated!

Name Link
🪓 Triggered by f03cc08f04dcd4040d4ce2c1471dce95e21cead7
🍃 Generated commit c12114bde397d0e508df92d3090967d28dec272b
🌲 Generated branch generated/fix/ugly-log
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1765
javascript 1658
php 1444
csharp 1302
python 1140
java 1003
ruby 824
swift 708
scala 23

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test was broken and not testing anything

shortcuts
shortcuts previously approved these changes Oct 15, 2025
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@millotp
Copy link
Collaborator Author

millotp commented Oct 15, 2025

sorry @shortcuts I missed a line in scala

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg!

@millotp millotp merged commit ccb9c37 into main Oct 15, 2025
29 checks passed
@millotp millotp deleted the fix/ugly-log branch October 15, 2025 10:05
algolia-bot added a commit that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants