chore(scripts): accurate cache for building docs #5480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
previously approved these changes
Oct 15, 2025
scripts/specs/format.ts
Outdated
| folder: toAbsolutePath('specs/'), | ||
| generatedFiles: [], | ||
| filesToCache: ['common'], | ||
| dependsOn: ['common'], |
scripts/cache.ts
Outdated
|
|
||
| for (const fileToCache of this.filesToCache) { | ||
| hash += (await hashElement(`${this.folder}/${fileToCache}`)).hash; | ||
| for (const file of this.dependsOn) { |
There was a problem hiding this comment.
dependsOn could also be named dependencies so we have a singular form
nitpick though
shortcuts
approved these changes
Oct 15, 2025
algolia-bot
added a commit
that referenced
this pull request
Oct 15, 2025
…[skip ci] Co-authored-by: Pierre Millot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The cache for
yarn cli build specs -dwas broken and didn't take the snippets or the correct output file into account, now it should be pixel perfect.Also fix some types, refactor the cache, and avoid a double call to
bundleSpecsForDoc! it was calling this even forjsonoutput, which is not needed.