Skip to content

Conversation

ClaraMuller
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-594
Mitigation for #5477 in the meantime.

Changes included:

Add facets parameter as a potential value for run endpoint as it is allowed in the payload

🧪 Test

  • CI
  • Run locally yarn cli build specs all && yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team as a code owner October 16, 2025 13:44
@ClaraMuller ClaraMuller requested review from a team, millotp and shortcuts October 16, 2025 13:44
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 16, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 826cd6489e7c7eb2eeb994b06af3c964d117772a
🍃 Generated commit e6adb1422b21d728370b376cae8e59bce7062220
🌲 Generated branch generated/clara/feat/specs/facet-available-in-run-endpoint
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1766
javascript 1615
php 1451
csharp 1451
python 1133
java 1000
ruby 788
swift 330
scala 23

@ClaraMuller
Copy link
Contributor Author

Hello @millotp as a mitigation of #5477, I created this PR, but even without re-defining anything, I have some issues.

@shortcuts
Copy link
Member

shortcuts commented Oct 16, 2025

this one is expected @ClaraMuller you need to add IndexSettingsFacets to https://github.com/algolia/api-clients-automation/blob/main/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java#L32, swift have one big bundle that prevents duplicate names between its sub packages (search, composition)

@ClaraMuller
Copy link
Contributor Author

Thanks @shortcuts I am not confortable modifying this, can I get your help on this ?

@millotp
Copy link
Collaborator

millotp commented Oct 16, 2025

Hey @ClaraMuller, actually it was the same name clashing issue as the last PR, I did some renaming and now there is no conflicts for facets anymore, is this what you expected to generate ?

@ClaraMuller
Copy link
Contributor Author

@millotp it seems that @shortcuts was suggesting an other solution

@millotp
Copy link
Collaborator

millotp commented Oct 16, 2025

it seems that @shortcuts was suggesting an other solution

I spoke with @shortcuts, it wouldn't have worked, the issue was with redocly, not openapi-generator, so we need to fix the spec before changing the generator

@ClaraMuller
Copy link
Contributor Author

Oh I see in that case if does generate a proper parameter called facets (which is my goal here) let's do it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants