Skip to content

Conversation

@ClaraMuller
Copy link
Contributor

@ClaraMuller ClaraMuller commented Jan 6, 2026

🧭 What and Why

Removing fields marked as required.
If the customer is modifying responseFields as allowed by the API, there is no guarantee that these fields are in the result set.

➡️ This behaviour exists from day 1 in the Composition API

🧪 Test

CI

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 6, 2026

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 44030f256b0f53633fb33103f6cea259c1ad10a4
🍃 Generated commit 855c6a88cb6df0288c2f5f6bb88123a9a7a154f1
🌲 Generated branch generated/clara/feat/remove-fields-required-from-response
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2442
go 2202
php 1936
csharp 1474
python 1355
java 1168
ruby 903
swift 350
scala 23

@ClaraMuller ClaraMuller changed the title feat(specs): remove fields requirement from run response in CompAPI client fix(specs): remove fields requirement from run response in CompAPI client Jan 6, 2026
@ClaraMuller ClaraMuller marked this pull request as ready for review January 6, 2026 13:27
@ClaraMuller ClaraMuller requested a review from a team as a code owner January 6, 2026 13:27
@ClaraMuller ClaraMuller requested a review from e-krebs January 6, 2026 15:00
Copy link
Contributor

@gavinwade12 gavinwade12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we need to do anything special since this could be a breaking change in some languages?

@shortcuts shortcuts merged commit cd7a174 into main Jan 6, 2026
71 checks passed
@shortcuts shortcuts deleted the clara/feat/remove-fields-required-from-response branch January 6, 2026 20:02
algolia-bot added a commit that referenced this pull request Jan 6, 2026
…ient (#5809) (generated) [skip ci]

Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 6, 2026
…ient (generated)

algolia/api-clients-automation#5809

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
@ClaraMuller
Copy link
Contributor Author

@gavinwade12 I discussed the topic with the team here: https://algolia.slack.com/archives/C336MP4UA/p1767704804486189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants